On Mon, 12 Sep 2005, Franck wrote: > Hi, > > I have a question about "usb_release_bandwidth": > > "usb_release_bandwidth" needs an urb as parameters. If I understand, > this function is called when periodic pipes is released ie when an ep > is disabled.
No. The bandwidth is released when there are no more URBs queued for the endpoint. That happens when usb_hcd_giveback_urb returns. usb_release_bandwidth should not be called when the endpoint is disabled. > This is normally done in "xxx_endpoint_disable" where xxx > is an hcd. But this function doesn't have any urb reference since the > endpoint should be empty (is it always true ?). If this is correct, > can we change the prototype of "usb_release_bandwidth" into: > > void usb_release_bandwidth (struct usb_device *dev, int > bustime, int isoc) > > ^^^^^^^^^^^ > Thanks, It's certainly true that the bandwidth management in usbcore is pretty bad. We need a thorough revision, not just this single change. Alan Stern ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
