On Wed, 14 Sep 2005, Bill Rees wrote: > Hi All, > While working on a driver for an in-house built usb board, I found > that even when the board failed to register the id strings were printed > out. This ended up confusing me for a short while as I expected the > strings to only show up if the device registered successfully. > > What about moving the getstring/showstring sequences to after the > usb_set_configuration if bracket? This would ensure that the device id > strings print out only if the usb_new_device registered the client > successfully. What does everyone think?
Those ID strings are useful for debugging, if nothing else. My preference is to leave the print statements where they are, and change the routine so that failure of usb_set_configuration isn't fatal. In fact, that's what I did in a patch recently posted for comments: http://marc.theaimsgroup.com/?l=linux-usb-devel&m=112569555202368&w=2 Alan Stern ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
