On Wed, 21 Sep 2005, David Kubicek wrote: > On Wed, Sep 21, 2005 at 06:32:05PM +0200, Oliver Neukum wrote: > > Am Mittwoch, 21. September 2005 14:51 schrieb David Kubicek: > > > Hello all, > > > > > > I am sorry for being so slow with the new patch - didn't really have > > > time for hacking on that last month. This patch is against the latest > > > stable kernel version, 2.6.13.2. I have addressed all of Olivers' notes > > > and suggestions from the last time, so there shouldn't be any work with > > > it's inclusion in 2.6.14 (usb_alloc_buffer instead kmalloc, debuging > > > messages and a couple of checks). > > > > Very good, but a few issue still, I am afraid. > Hello, here's the updated and retested patch, including all changes. > > > This is in interrupt. Please use the simple form of the locks. > I'd like to find out the difference between and in which context to > use the following locking -- could anyone help, please (even URL)? > 1) spin_lock_irqsave > 2) spin_lock_irq > 3) spin_lock
linux/Documentation/spinlocks.txt linux/Documentation/DocBook/kernel-locking* (but this requires using "make htmldocs" or "make psdocs" or "make pdfdocs", and "make htmldocs" seems to be the only one that is reliable atm due to some tools issues). http://lwn.net/Kernel/LDD3/ chapter 5 > > Please rename the structure so it is not mistaken for the actual buffer. > I have renamed some other structures and variables as well to blend them > in with existing code. > > Thank you, Oliver, for your evaluation and hints. See you, -- ~Randy ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
