On Thu, 22 Sep 2005, David Brownell wrote: > Here are a bunch of USB updates, many making power management > become simpler, for 2.6.15.early merging. They go on top of > 2.6.14-rc2 with the patches already in Greg's queue [1].
There are a few things in here I don't like. > * PM updates for usbcore. This is the stuff that simplifies > things by making CONFIG_USB_SUSPEND mean a lot less. > > - pm-root1.patch ... a handful of PM updates that don't > directly affect much else; e.g. a new method that > can make OHCI autosuspend work again. > > - pm-root2.patch ... gets rid of lots of special cases > and merges most of the USB_SUSPEND logic in > with normal PM support. Mostly in these, although maybe in a few of the others as well. The main thing is moving hcd->hub_suspend into hub.c:hub_suspend. I firmly believe that the model you're using for root hubs isn't as logical or as consistent with external hubs as the one I outlined. Another thing is the way you're doing autosuspend in OHCI (and probably EHCI as well -- I haven't checked). There's nothing new about this, but these patches just seem to move farther down the wrong path. Also, what goes wrong when you try to use the FREEZE/SUSPEND distinction? You mentioned only that it doesn't work. For the sake of making forward progress, I won't object to having these patches applied. But there are a few parts I will want to alter or change back. Alan Stern ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
