> Actually that was pretty much okay, except for this one question about > hub_resume. It was a big set of patches; there hasn't been time to review > it carefully...
That's why I broke it up into more easily-reviewable chunks. :) > > > The main thing is moving hcd->hub_suspend into hub.c:hub_suspend. I > > > firmly believe that the model you're using for root hubs isn't as logical > > > or as consistent with external hubs as the one I outlined. > > > > Seems plenty logical to me: hub suspend code handles hub suspend, > > whether or not it's a root hub. Ditto with resume code. The > > But hub.c:hub_suspend (which is what you mean by "hub suspend code", I > trust?) _doesn't_ handle hub suspend. It handles hub _interface_ suspend. > Well, let's leave this to the other email thread. Discussion doesn't belong there though ... if you follow up to the post I just made (elaborating on why it's right to have hub_suspend only handle downstream ports), I think patch 5/12 is probably a better context. > > If by "wrong path" you mean "not the khubd-driven approach that's been > > slightly discussed" ... well, we don't have any such code yet, and it's > > not OK to leave OHCI broken until we do. > > Okay, but this should be regarded only as a temporary fix. The old code > went to some lengths to carry out an autosuspend from within an interrupt > context, and this just piles on more of the same. Well, "irqs blocked"; not really an interrupt context. And I still don't see a way to really get around blocking IRQs while entering the OHCI suspend state!! > Instead, the > interrupt-level code should arrange for some thread to do a real suspend, > in process context. Yet we don't have any such code yet ... and the current approach has worked for quite a while, modulo recent breakage fixed in these patches. What's there is just bugfixes for that breakage. :) If we get such usbcore code, I'd much rather see it phase in without breaking OHCI; it kind of sucks that 2.6.14 is going to go out with it still broken. - Dave ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
