Hi! Greg KH [2005-09-27 2:13 -0700]: > On Tue, Sep 27, 2005 at 01:04:15AM -0700, Greg KH wrote: > > First off, thanks for providing a patch for this problem, it is real, > > and has been known for a while (thanks to your debugging :) > > > > On Sun, Sep 25, 2005 at 05:13:30PM +0200, Harald Welte wrote: > > > > > > I suggest this (or any other) fix to be applied to both 2.6.14 final and > > > the stable series. I didn't yet investigate 2.4.x, but I think it is > > > likely to have the same problem. > > > > I agree, but I think we need an EXPORT_SYMBOL_GPL() for your newly > > exported symbol, otherwise the kernel will not build if you have USB > > built as a module. > > Hm, it's even messier. With your patch, we get: > *** Warning: "__send_sig_info" [drivers/usb/core/usbcore.ko] undefined! > *** Warning: "__put_task_struct" [drivers/usb/core/usbcore.ko] > undefined! > when the USB core is a module. > > I can't pass judgement if we want to export both of these functions to > modules... Anyone else know?
FWIW, our kernel maintainer just added EXPORT_SYMBOL_GPL(__send_sig_info); and it worked fine (we modularize as much as possible). Martin -- Martin Pitt http://www.piware.de Ubuntu Developer http://www.ubuntu.com Debian Developer http://www.debian.org In a world without walls and fences, who needs Windows and Gates? ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel