On Sun, 25 Sep 2005, Harald Welte wrote:
>
> async_completed() calls send_sig_info(), which in turn does a
> spin_lock(&tasklist_lock) to protect itself from task_struct->sighand
> from going away. However, the call to
> "spin_lock_irqsave(task_struct->sighand->siglock)" causes an oops,
> because "sighand" has disappeared.
And the real bug is that you're buggering up the system in the first
place.
You don't save "current". You save "pid", and then you send a signal using
that and kill_proc_info(). End of story, bug gone. And it works with
threaded programs too, which the old thing didn't work at all with.
I refuse to apply this patch - Greg, don't even _try_ to sneak this in
through a git merge. What a horribly broken thing to do: why would USB
_ever_ need to know about things like tasklist_lock, and internal signal
handling functions and rules like "p->sighand"?
Linus
-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
