On Fri, 7 Oct 2005, Maciej W. Rozycki wrote: > Alan, > > > Did you originally write this patch to disable legacy USB support on the > > PIIX3: > > > > http://marc.theaimsgroup.com/?l=linux-kernel&m=95970150511031&w=2 > > Yes. > > > If so, can you say whether the quirk_piix3_usb routine is still needed? > > I have no faintest idea. The system I have tested it with is currently > far away (though I still have it). > > > There is now a separate routine that takes care of the BIOS handoff for > > all UHCI controllers, so unless the PIIX3's controller doesn't identify > > itself as UHCI, we shouldn't need your special function. > > Can you please point me at the responsible bits? Are they always > executed, especially if support for USB is disabled? The PIIX3's USB > controller function identifies itself correctly; I can send you a dump > suitable for `lspci -F' to inspect if interested.
As of 2.6.14-rc3, everything is still in drivers/pci/quirks.c. In Greg K-H's development tree, the USB portions of that file have been separated out and are now in drivers/usb/host/pci-quirks.c. Greg's tree is available at http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-all-2.6.14-rc3.patch At the start of this email thread, I submitted a patch that unifies the PCI UHCI quirk handling and the uhci-hcd controller reset routines. That patch can be found here: http://marc.theaimsgroup.com/?l=linux-usb-devel&m=112837224319215&w=2 Once this patch is merged, it should be safe always to call the quirk_usb_handoff_uhci routine -- regardless of the usb-handoff setting and regardless of whether USB support is built into the kernel. Hence your routine would not be needed any more. Basically, I believe the problem your routine solved was not unique to the PIIX3. It arose because the BIOS leaves the USB interrupts enabled and the controller running, and it can happen on any system where the BIOS supports legacy USB devices. So the standard routines for kicking the BIOS off the controller should work for the PIIX3 as well as for anything else. Alan Stern ------------------------------------------------------- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
