On Sat, 8 Oct 2005, Pete Zaitcev wrote: > On Fri, 7 Oct 2005 10:41:14 -0400 (EDT), Alan Stern <[EMAIL PROTECTED]> wrote: > > > > --- linux-2.6.14-rc2/drivers/usb/storage/usb.h 2005-09-24 > > > 20:32:56.000000000 -0700 > > > +++ linux-2.6.14-rc2-wip/drivers/usb/storage/usb.h 2005-10-06 > > > 21:37:10.000000000 -0700 > > ... > > > -/* Dynamic flag definitions: used in set_bit() etc. */ > > > -#define US_FLIDX_URB_ACTIVE 18 /* 0x00040000 current_urb is in > > > use */ > > > -#define US_FLIDX_SG_ACTIVE 19 /* 0x00080000 current_sg is in use > > > */ > > > I would prefer to keep these definitions in the usb-storage driver. They > > refer to dynamic aspects of an individual device, not static blacklist or > > ID-matching for all devices of a particular type. As such, they are of no > > interest to ub or libusual. > > OK > > > > + * Observe that usb-storage blatantly mixes set_bit() and normal > > > + * shift and mask operations on flags, which is strictly illegal. > > > + * And it probably even works for all flags except GO_SLOW and > > > NO_WP_DETECT. > > > Once the device is running, the shift/mask operations are used _only_ for > > reading, never for writing. > > OK > > How about now?
This is better, thank you. Alan Stern ------------------------------------------------------- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
