2005/10/14, David Brownell <[EMAIL PROTECTED]>:
> > We will still have the problem that the HCDs don't have access to the
> > spinlock that protects the queue pointers. I suppose the spinlock could
> > be EXPORTed.
>
> That problem is ... what?  Exporting that lock would imply there's some
> good reason for code other than usbcore to use it.  I haven't seen one.
>

maybe one of the reasons is that you use ep's queue without holding
any usbcore's locks in sl811 hcd...

BTW, I noticed something strange in "hcd_endpoint_disable". If I well
understand this function parse the ep's queue and free each of them by
(a) calling hcd->urb_dequeue method (b) kfreeing urb....Don't we need
to remove the urb from ep's queue somewhere before the queue is
rescaned from the start ?

Thanks
--
               Franck


-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to