On Tue, Oct 18, 2005 at 03:04:46PM -0700, Pete Zaitcev wrote:
> On Tue, 18 Oct 2005 16:44:23 -0400 (EDT), Alan Stern <[EMAIL PROTECTED]>
> wrote:
>
> > - if (pdev->class == ((PCI_CLASS_SERIAL_USB << 8) | 0x00)) { /* UHCI */
> > + if (pdev->class ==
> > + ((PCI_CLASS_SERIAL_USB << 8) | 0x00)) /* UHCI */
> > quirk_usb_handoff_uhci(pdev);
> > - } else if (pdev->class == ((PCI_CLASS_SERIAL_USB << 8) | 0x10)) { /*
> > OHCI */
> > + else if (pdev->class ==
> > + ((PCI_CLASS_SERIAL_USB << 8) | 0x10)) /* OHCI */
> > quirk_usb_handoff_ohci(pdev);
> > - } else if (pdev->class == ((PCI_CLASS_SERIAL_USB << 8) | 0x20)) { /*
> > EHCI */
> > + else if (pdev->class ==
> > + ((PCI_CLASS_SERIAL_USB << 8) | 0x20)) /* EHCI */
> > quirk_usb_disable_ehci(pdev);
>
> This is fugly. Move comments inside blocks.
I agree. I suggest adding the USB ids for these values to pci_ids.h and
then use them. Then no comment would be needed at all.
Alan, care to redo this?
thanks,
greg k-h
-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
