On Fri, 7 Oct 2005 04:00:51 -0400 (EDT), Keith Winstein <[EMAIL PROTECTED]> 
wrote:

> Unfortunately, for devices with more than 64 elements in their reports
> (such as the X-keys Jog & Shuttle Editor, which has a wDescriptorLength of
> 91, and the X-keys Joystick Controller, with wDescriptorLength = 78), this
> makes the ring buffer writer (in hiddev_send_event()) write over itself
> before the reader (in hiddev_read()) can even get a change to read the
> beginning of the report. The result is incorrect output -- keys that never
> get reported to user space.

Well, that's fine, but this is certainly overdoing it:

> -#define HIDDEV_BUFFER_SIZE   64
> +#define HIDDEV_BUFFER_SIZE   1024

That's 24 KILOBYTES of zeroes. Not to mention that anything larger than
two pages worth is nearly impossible to allocate...

Why in the world do you need a thousand of entries?

-- Pete


-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.
Get Certified Today * Register for a JBoss Training Course
Free Certification Exam for All Training Attendees Through End of 2005
Visit http://www.jboss.com/services/certification for more information
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to