On Tue, 25 Oct 2005, Greg KH wrote: > That's nice, but you are now generating hotplug events for endpoints. > Are you sure we want to do this?
No, it was an unintentional effect. I didn't realize the kobject_register does more than just kobject_init followed by kobject_add. (By comparison, device_register really is exactly the same as device_initialize followed by device_add.) It's simple enough to fix; just replace the one call with the two (and the same for unregister). > You also removed the following two attributes: > > > -usb_ep_attr(bDescriptorType, "%02x\n") > > -usb_ep_attr(bEndpointAddress, "%02x\n") > > I saw that you mentioned that we don't need the address, as it's in the > directory name, but I would argue that we should have it anyway, as it's > hard for some shell languages to parse out the address from the > directory name. > > The decriptor type is fine to remove, as you are right, it is redundant. There's no problem adding the address back in. I'll send a revised patch with these two changes. Alan Stern ------------------------------------------------------- This SF.Net email is sponsored by the JBoss Inc. Get Certified Today * Register for a JBoss Training Course Free Certification Exam for All Training Attendees Through End of 2005 Visit http://www.jboss.com/services/certification for more information _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
