Am Freitag, 11. November 2005 10:39 schrieb Herbert Xu:
> On Thu, Nov 10, 2005 at 08:38:16PM +1100, herbert wrote:
> > 
> > In fact even now it is possible to get those printks from the resubmit
> > function if usb_kill_urb() fails to kill it using unlink.
> > 
> > I'll send you a patch for that tomorrow.
> 
> Here is the patch that I promised:
> 
> 
> [KAWETH] Suppress errors when URB is unlinked
>     
> When an URB is unlinked the completion function will be called with
> a non-zero status value.  Since we can recognise those specific values
> we shouldn't print an error message when we detect them.

+       switch (urb->status != 0) {

1. This is surely not what is intended.
2. Would you please leave in unlikely in interrupt handlers.
3. -ENOMEM with GFP_KERNEL is not something to write a log entry about.

        Regards
                Oliver


-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to