A few minor comments...
On Wed, 16 Nov 2005, Greg KH wrote:
> +static ssize_t store_new_id(struct device_driver *driver,
> + const char *buf, size_t count)
> +{
> + struct usb_driver *usb_drv = to_usb_driver(driver);
> + struct usb_dynid *dynid;
> + u32 idVendor = 0;
> + u32 idProduct = 0;
> + int fields = 0;
> +
> + fields = sscanf(buf, "%x %x", &idVendor, &idProduct);
> + if (fields < 0)
> + return -EINVAL;
Don't you want to test (fields < 2)?
> + if (get_driver(&usb_drv->driver)) {
> + driver_attach(&usb_drv->driver);
> + put_driver(&usb_drv->driver);
> + }
Here you don't have to refer to &usb_drv->driver; you can just refer to
driver.
> +static int usb_create_newid_file(struct usb_driver *usb_drv)
> +{
> + int error = 0;
> +
> + if (usb_drv->probe != NULL)
> + error = sysfs_create_file(&usb_drv->driver.kobj,
> + &driver_attr_new_id.attr);
> + return error;
> +}
This deserves to be an inline function.
> +static void usb_free_dynids(struct usb_driver *usb_drv)
> +{
> + struct usb_dynid *dynid, *n;
> +
> + spin_lock(&usb_drv->dynids.lock);
> + list_for_each_entry_safe(dynid, n, &usb_drv->dynids.list, node) {
> + list_del(&dynid->node);
> + kfree(dynid);
> + }
> + spin_unlock(&usb_drv->dynids.lock);
> +}
This could be inline as well, although being longer, its overhead is less
noticeable.
Alan Stern
-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc. Get Certified Today
Register for a JBoss Training Course. Free Certification Exam
for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
