On Sat, Nov 26, 2005 at 04:01:06PM -0500, Alan Stern wrote: > On Sat, 26 Nov 2005, Ville Syrjälä wrote: > > > Here's a new driver for ATI/Philips USB RF remote controls. The hardware > > is made by Philips but the ATI Remote Wonder II is the only device I > > know to use this hardware. > > > > I'm hoping some USB/input gurus will point out any problems with the > > code. > > > > The device has two interfaces, one for the mouse pad and the other for > > the keys. So usb_driver_claim_interface() must be used. > > > > What is the purpose of input_regs()?
To inform the input layer of the state of the registers at the time of the event. This allows sysrq and other magic keys to display the current CPU state. It is optional. > > What is the purpose of input_sync()? To inform the input layer that what you've reported before is a full state report and that it should be pushed to further processing. It is absolutely required. > > What values can urb->status have under normal use? Currently I don't > > print an error message for -ENOENT, -EILSEQ and -ESHUTDOWN because they > > occur when I rmmod the driver or unplug the device. > > Read Documentation/usb/error-codes.txt. > > > Doing rmmod/insmod or unplug/plug a few times causes kernel oopses. A > > simple usb test module which does nothing but register/unregister an > > input device in the probe()/disconnect() callbacks exhibits the same > > behaviour. I'm running 2.6.14-mm1 currently. Are there know problems > > with that kernel that could cause the oopses? > > If they were known, they'd be fixed. :-) > > Can you post an example of a very simple test driver along with a kernel > log showing the oops messages? Try using 2.6.15-rc2 or something similar. > > Alan Stern > > > > ------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. Do you grep through log files > for problems? Stop! Download the new AJAX search engine that makes > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! > http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click > _______________________________________________ > linux-usb-devel@lists.sourceforge.net > To unsubscribe, use the last form field at: > https://lists.sourceforge.net/lists/listinfo/linux-usb-devel > -- Vojtech Pavlik SuSE Labs, SuSE CR ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_idv37&alloc_id865&op=click _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
