On Thu, 1 Dec 2005, Greg KH wrote:
> Hi all,
>
> Here's a patch that adds Takahiro's USB over IP patch to the kernel
> tree. It's still a bit rough around the edges, so I'd like to get some
> comments and reviews from others. Especially those who know the USB HCD
> interface better than I (David and Alan...)
I took a quick look through it.
There are a lot of things that could stand to be improved. Unnecessary
use of spinlocks, memory leaks, sysfs races... Here's a good example of
something that should be fixed:
priv->seqnum = atomic_read(&the_controller->seqnum);
atomic_inc(&the_controller->seqnum);
On the whole, the enterprise is interesting. There are some significant
holes: incomplete support for unlinking, no support for suspend/resume.
Also the HCD code is a couple of kernel versions behind the current state
of affairs.
At the very least, the Kconfig entry should be marked EXPERIMENTAL. And
it needs to have help entries added.
Alan Stern
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
