On Wed, Jan 04, 2006 at 01:18:45PM +0100, Juergen Schindele wrote:
> Hello developers
> 
> i propose a patch for touchkitusb.c.
> On my platform (PXA270 ohci) the driver is only
> working with the following patch.
> 
> It contains two parts
> - initialize urb->transfer_flags/dma (as done in hid-core.c)
> - simulate a pressure-value for tslib(input-raw)
> 
> If you judge this patch useful please implement it for furter releases

Hm, your patch has some problems in it.  Can you resubmit it after
reading the file Documentation/SubmittingPatches and adding the proper
Signed-off-by: line?

>  --- kernel-2.6.15.orig/drivers/usb/input/touchkitusb.c  2005-12-19 
> 11:56:51.000000000 +0100
> +++ kernel-2.6.15/drivers/usb/input/touchkitusb.c       2006-01-04 
> 12:23:51.000000000 +0100

The patch is linewrapped and can't be applied :(

> @@ -42,6 +42,8 @@
>  #define TOUCHKIT_YC_FUZZ               0x0
>  #define TOUCHKIT_YC_FLAT               0x0
>  #define TOUCHKIT_REPORT_DATA_SIZE      8
> +#define PRESSURE_MIN                   0
> +#define PRESSURE_MAX                   15
> 
>  #define TOUCHKIT_DOWN                  0x01
>  #define TOUCHKIT_POINT_TOUCH           0x81
> @@ -114,10 +116,16 @@
>         }
> 
>         input_regs(touchkit->input, regs);
> -       input_report_key(touchkit->input, BTN_TOUCH,
> -                        TOUCHKIT_GET_TOUCHED(touchkit->data));

All of your tabs are stripped :(

thanks,

greg k-h


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to