Hi!
> http://projects.o-hand.com/hx2750/patches/usb_pxa27x_udc-r0.patch
>
> is the pxa27x driver itself. I've taken the one from handhelds.org and
> made changes to get full CDC-Ethernet running with it instead of
> CDC-Subset by handling the pxa27x specific configuration issues
> properly. I've also started the process of cleaning up the style a bit
> although there's still a way to go. This patch is now being used in the
> Zaurus kernel tree and there are a couple of Zaurus specific lines of
> code in there which can easily be abstracted to the platform data.
Looks good to me....
> Any collaboration on improving this code would be welcome. I'd also be
> interested in a rough indication as to what needs doing to the driver
> itself before it can be merged into mainline linux. At a minimum I
> suspect it needs:
>
> 1. Coding style changes to be completed / code cleanup (removal of
> pxa25x related comments)
1a. removal of //'s
1b. removal of its own debugging infrastructure.
+#define WARN(stuff...) printk(KERN_WARNING "udc: " stuff)
+#define INFO(stuff...) printk(KERN_INFO "udc: " stuff)
...should go.
Pavel
--
Boycott Kodak -- for their patent abuse against Java.
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
