Am Samstag, 7. Januar 2006 23:05 schrieb Pete Zaitcev:
> On Sat, 7 Jan 2006 21:35:20 +0100 (CET), Oliver Neukum <[EMAIL PROTECTED]>
> wrote:
>
> > -general cleanup
>
> > It compiles and I am printing.
>
> Personallo, I cannot stand our wait_event interface. Its locking properties
> are extremely fishy and it adds insane obfuscation (basically people
> who pass conditional statements into macros have to sit in the corner
> and rethink their lives).
>
> If you want to add check for ->present, it's fine, but adding wait_event
> is nothing but a pointless obfuscation.
I can't argue personal taste. If you have better ideas about implementing
waiting helpers, implement them and I'll use them. Until then what but
the more or less canonical ways do you expect me to use? Compared to
the old code, they _are_ an improvement.
Regards
Oliver
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
