On Fri, 20 Jan 2006, Pete Zaitcev wrote:
> On Fri, 20 Jan 2006 09:33:26 +0100 (CET), Guennadi Liakhovetski <[EMAIL
> PROTECTED]> wrote:
>
> > Looks like a bug?
>
> > --- a/drivers/usb/host/usb-uhci.c Fri Jan 20 09:27:50 2006
> > +++ b/drivers/usb/host/usb-uhci.c Fri Jan 20 09:28:05 2006
> > @@ -2505,7 +2505,7 @@
> > ((urb_priv_t*)urb->hcpriv)->flags=0;
> > }
> >
> > - if ((urb->status != -ECONNABORTED) && (urb->status !=
> > ECONNRESET) &&
> > + if ((urb->status != -ECONNABORTED) && (urb->status !=
> > -ECONNRESET) &&
> > (urb->status != -ENOENT)) {
>
> This is not what the author intended, obviously. But I am not quite sure
> what happens because of it. Seems like we unlink some things which are
This is my concirn too. The current behaviour is in fact just
> > - if ((urb->status != -ECONNABORTED) && (urb->status !=
> > ECONNRESET) &&
> > + if ((urb->status != -ECONNABORTED) &&
> > (urb->status != -ENOENT)) {
and nobody complains...:-) So, maybe this would be the right fix? At least
safe in that it cannot break anything:-) But I don't understand that code
very well. E.g., I don't understand why about 15 lines above the code in
question
if (urb->complete) {
//dbg("process_interrupt: calling completion, status
%i",status);
urb->status = status;
i.e., if (!urb->completion) urb->status is not set, so, depending on
whether the urb has ->completion either the old or the new status will be
tested. Is this really correct? And a couple lines above that "goto
recycle;" is superfluous...
Thanks
Guennadi
> about to return anyway... and then return -104 instead of -84. This
> may be relatively harmless. At worst, the driver resubmits and gets
> its -84 that way.
>
> I vote to apply this and see what happens. We are early in 2.4.33 cycle,
> so it should be safe.
>
> -- Pete
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
---
Guennadi Liakhovetski
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
