On 11.02.2006 [15:52:27 +0100], Hansjoerg Lipp wrote:
> From: Tilman Schmidt <[EMAIL PROTECTED]>, Hansjoerg Lipp <[EMAIL PROTECTED]>
> 
> This patch adds the common include file for the Siemens Gigaset drivers,
> providing definitions used by all of the Gigaset ISDN driver source files.
> It also adds the main source file of the gigaset module which manages
> common functions not specific to the type of connection to the device.

<snip>

> +#define GIG_TICK (HZ / 10)

This should probable be in milliseconds and use msecs_to_jiffies either
with another #define, or in the code directly (as Greg also indicated).
That way, we avoid rounding issues as best we can with HZ==250.

<snip>

> +/* gigaset_initcs
> + * Allocate and initialize cardstate structure for Gigaset driver
> + * Calls hardware dependent gigaset_initcshw() function
> + * Calls B channel initialization function gigaset_initbcs() for each B 
> channel
> + * parameters:
> + *      drv          hardware driver the device belongs to
> + *   channels        number of B channels supported by device
> + *   onechannel      !=0: B channel data and AT commands share one 
> communication channel
> + *                   ==0: B channels have separate communication channels
> + *   ignoreframes    number of frames to ignore after setting up B channel
> + *   cidmode         !=0: start in CallID mode
> + *   modulename      name of driver module (used for I4L registration)
> + * return value:
> + *   pointer to cardstate structure
> + */
> +struct cardstate *gigaset_initcs(struct gigaset_driver *drv, int channels,
> +                              int onechannel, int ignoreframes,
> +                              int cidmode, const char *modulename)
> +{

<snip>

> +     cs->timer.data = (unsigned long) cs;
> +     cs->timer.function = timer_tick;
> +     cs->timer.expires = jiffies + GIG_TICK;

setup_timer()?

Thanks,
Nish


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to