On Thursday 23 February 2006 12:18 pm, Thomas Brinker wrote:
> 
> This adds support for the FHG_USB32 IP-Core Modul from emsys GmbH 
> and Fraumhofer Gesellschaft.

But the patch STILL has the issues noted in previous posts ... line
wrapping all over the patch itself, one-character indents (just fix
those and other coding style goofs by running Lindent), labels not
aligned at left margin, and more.  You don't seem to have made those
requested fixes after your original post in October...

See a few other comments below.

- Dave


> + spin_lock_irqsave(&dev->lock, flags);
> +       tmp = FHG_USB32_FRM_TIMER & USB_FRAME_NR_MSK;
> +       spin_unlock_irqrestore(&dev->lock, flags);

Observe the internally-inconsistent indenting; and it's not clear
why that should-be-readl() would merit a spinlock...


> +static struct device_driver udc_driver = {
> +       .name = "fhg_usb32-udc",
> +       .bus = &platform_bus_type,
> +       .probe = fhg_usb32_udc_probe,
> +       .remove = __exit_p(fhg_usb32_udc_remove),
> +
> +};

This should be a "platform_driver" with current kernels.


> +typedef volatile u8 *FHG_USB32_FIFO_ptr;
> ...
> +volatile FHG_USB32_FIFO_ptr out_fifo[6] = {

That should be "static" not "volatile"; and you shouldn't have any
typedefs.  You should be using accessors like "readl" and "writel"
rather than using "volatile" declarations.


> +static inline void make_usb_disappear(void)

You'll note that current versions of the pxa2xx_udc code fix that
historical botch ... such functions are now mnemonically named,
as pullup_on() and pullup_off(), also is_vbus_connected().  Please
don't perpetuate mistakes that have been fixed since May 2005...



-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to