On 2/24/06, Greg KH <[EMAIL PROTECTED]> wrote: > On Fri, Feb 24, 2006 at 10:05:47AM -0500, Andrew Fuller wrote: > > This patch is for the Dual USB Joypad [0925:8866] from Wisegroup. The > > HID_QUIRK_NOGET is necessary for it to respond to input, and the > > HID_QUIRK_MULTI_INPUT is necessary to have two js# nodes appear. > > > > This patch has been confirmed by two other people aside from myself, > > so I would like it included in the kernel at the next opportunity. > > Oops, you forgot a "Signed-off-by:" line, as per the directions in > Documentation/SubmittingPatches. > > Care to try it again? > > thanks, > > greg k-h
Sorry I missed the SubmittingPatches document (this is my first kernel patch). Let's try this again. I've recreated the patch using vanilla sources 2.6.16_rc4 and added the '-p' option to diff, which I didn't have in the last patch. Again, the NOGET flag is to get it to work, and the MULTI_INPUT is so it separates the two inputs. Signed-off-by: Andrew Fuller <mactalla . obair AT gmail . com> -Andrew
--- linux-2.6.16-rc4/drivers/usb/input/hid-core.c.orig 2006-02-25 09:15:01.000000000 -0500 +++ linux-2.6.16-rc4/drivers/usb/input/hid-core.c 2006-02-25 09:33:56.000000000 -0500 @@ -1407,6 +1407,7 @@ void hid_init_reports(struct hid_device #define USB_VENDOR_ID_WISEGROUP 0x0925 #define USB_DEVICE_ID_1_PHIDGETSERVO_20 0x8101 #define USB_DEVICE_ID_4_PHIDGETSERVO_20 0x8104 +#define USB_DEVICE_ID_DUAL_USB_JOYPAD 0x8866 #define USB_VENDOR_ID_CODEMERCS 0x07c0 #define USB_DEVICE_ID_CODEMERCS_IOW40 0x1500 @@ -1577,6 +1578,7 @@ static const struct hid_blacklist { { USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_CHICONY_USBHUB_KB, HID_QUIRK_NOGET}, { USB_VENDOR_ID_HP, USB_DEVICE_ID_HP_USBHUB_KB, HID_QUIRK_NOGET }, { USB_VENDOR_ID_TANGTOP, USB_DEVICE_ID_TANGTOP_USBPS2, HID_QUIRK_NOGET }, + { USB_VENDOR_ID_WISEGROUP, USB_DEVICE_ID_DUAL_USB_JOYPAD, HID_QUIRK_NOGET | HID_QUIRK_MULTI_INPUT }, { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_POWERMOUSE, HID_QUIRK_2WHEEL_POWERMOUSE }, { USB_VENDOR_ID_A4TECH, USB_DEVICE_ID_A4TECH_WCP32PU, HID_QUIRK_2WHEEL_MOUSE_HACK_7 },