On Fri, Mar 03, 2006 at 07:53:28AM +0100, Arjan van de Ven wrote: > On Fri, 2006-03-03 at 00:03 +0100, Tilman Schmidt wrote: ... > > > >>+#define IFNULL(a) \ > > >>+ if (unlikely(!(a))) > > > > > > please please get rid of this! > > > (same goes for the variants of this just below this) > > > > Ok, these were mainly debugging aids. We'll just drop them and let the > > oops mechanism catch the (hopefully non-existent) remaining cases of > > pointers being unexpectedly NULL. > > you can also use WARN_ON() and BUG_ON() for that, you then get a more > readable oops message (with filename and line information) >
Yes, but please only WARN_ON(), BUG_ON should be only used, if here is no way to recover or if continue will cause major data corruption, I do not think thats the case anywhere in the driver. -- Karsten Keil SuSE Labs ISDN development ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
