On Tue, 2006-03-14 at 23:04 +0100, Oliver Neukum wrote: > > What Paul needs to track is the refcount for acm->dev. It should be > > incremented and decremented appropriately -- which means that acm->dev had > > better not be NULL when acm_tty_unregister runs. > > The devices's control interface's refcount is bumped. Are you saying this is > not enough and the device's refcount must also be manipulated? > In which regard should the pointer be significant?
acm->dev (NULL or non-NULL) is only used as a flag in acm_tty_close() to determine if acm_tty_unregister() should be called or not. If NULL then the hardware is unplugged and acm_tty_unregister() is called. acm->dev is not used by acm_tty_unregister() itself or by the sysfs symlinks. Only acm->control->dev is used for the symlinks and that already has a reference for that purpose. It just may be that some other code does too many puts on acm->control->dev. We should find out tonight when Bob gives the latest printk patch a try. -- Paul Fulghum Microgate Systems, Ltd ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
