On Wednesday 15 March 2006 05.30, Lanslott Gish wrote:
> did you mean like that? thx.
>
> regards,
>
> Lanslott Gish
> ===================================================================
> --- linux-2.6.16-rc6.patched/drivers/usb/input/usbtouchscreen.c
> +++ linux-2.6.16-rc6/drivers/usb/input/usbtouchscreen.c
> @@ -49,6 +49,13 @@
> static int swap_xy;
> module_param(swap_xy, bool, 0644);
> MODULE_PARM_DESC(swap_xy, "If set X and Y axes are swapped.");
> +static int swap_x;
> +module_param(swap_x, bool, 0644);
> +MODULE_PARM_DESC(swap_x, "If set X axe is swapped before XY swapped.");
> +static int swap_y;
> +module_param(swap_y, bool, 0644);
> +MODULE_PARM_DESC(swap_y, "If set Y axe is swapped before XY swapped.");
> +
>
(i prefer invert_x and invert_y...)
>
> /* device specifc data/functions */
> @@ -224,13 +231,17 @@
> * PanJit Part
> */
> #ifdef CONFIG_USB_TOUCHSCREEN_PANJIT
> +
> static int panjit_read_data(char *pkt, int *x, int *y, int *touch, int
> *press)
> {
> - *x = pkt[1] | (pkt[2] << 8);
> - *y = pkt[3] | (pkt[4] << 8);
> + *x = (pkt[1] & 0x0F) | ((pkt[2]& 0xFF) << 8);
> + *y = (pkt[3] & 0x0F) | ((pkt[4]& 0xFF) << 8);
that just can't be right. you probably mean
+ *y = pkt[3] | ((pkt[4] & 0x0F) << 8);
otherwise you mask out bits 4-7. but you want to limit it to 12 bits...
(btw. no need for the & 0xFF mask since *pkt is char)
anyway, i updated the driver with all the comments i got so far.
will send out in a minute as a new mail.
rgds
-daniel
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
