On Sat, 2006-04-08 at 23:16 +0200, Guennadi Liakhovetski wrote: > On Sat, 8 Apr 2006, Paul Fulghum wrote: > > OK, this one backs out my usb_console_setup change > > that uses the temp tty structure for the device specific open. > > > > Included is: > > * improved usb serial_open fix (fix ENODEV) > > * improved usb_console_write fix (fix CR after LF) > > * your original ftdi patch (fix oops on tty struct == NULL) > > Yes, this one works.
Interesting, something about passing a dummy tty structure to the ftdi device specific open causes a lock up. I don't see an obvious problem. With the dummy tty, ftdi_set_termios is called twice (once in ftdi_open and once from usb_console_setup) in close proximity, maybe that is a problem. If it is, that would seem to be another bug someplace. What happens if you modify usb/serial/console.c:usb_console_setup to call serial->type->set_termios(port, NULL) twice in a row? (while still using the latest patch) > It, certainly, also still boots if I remove > tmp_termios from ftdi_sio.c. That seems to be the simplest method of correcting the uninitialized tmp_termios, and is consistent with how usb_console_setup calls the device specific set_termios. Thanks, Paul ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
