On Mon, 1 May 2006, Olaf Hering wrote:
> On Wed, Jan 25, Alan Stern wrote:
>
> > My earlier experiment (adding a clear-halt for the interrupt-in endpoint)
> > failed. It turns out that it does cause problems for other devices. And
> > it wasn't needed anyway; a simple blacklist entry was enough to get my HP
> > keyboard working.
> >
> > This patch (as643) removes the clear-halt call and adds the blacklist
> > entry.
>
> > +++ usb-2.6/drivers/usb/input/hid-core.c
> > @@ -1445,6 +1445,9 @@ void hid_init_reports(struct hid_device
> > #define USB_VENDOR_ID_CHERRY 0x046a
> > #define USB_DEVICE_ID_CHERRY_CYMOTION 0x0023
> >
> > +#define USB_VENDOR_ID_HP 0x03f0
> > +#define USB_DEVICE_ID_HP_USBHUB_KB 0x020c
> > +
> > /*
> > * Alphabetically sorted blacklist by quirk type.
> > */
> > @@ -1558,6 +1561,7 @@ static const struct hid_blacklist {
> > { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_4PORTKVMC, HID_QUIRK_NOGET },
> > { USB_VENDOR_ID_BTC, USB_DEVICE_ID_BTC_KEYBOARD, HID_QUIRK_NOGET},
> > { USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_CHICONY_USBHUB_KB,
> > HID_QUIRK_NOGET},
> > + { USB_VENDOR_ID_HP, USB_DEVICE_ID_HP_USBHUB_KB, HID_QUIRK_NOGET },
> > { USB_VENDOR_ID_TANGTOP, USB_DEVICE_ID_TANGTOP_USBPS2, HID_QUIRK_NOGET
> > },
> >
> > { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_POWERMOUSE,
> > HID_QUIRK_2WHEEL_POWERMOUSE },
> > @@ -1820,9 +1824,6 @@ static struct hid_device *usb_hid_config
> > hid->urbctrl->transfer_dma = hid->ctrlbuf_dma;
> > hid->urbctrl->transfer_flags |= (URB_NO_TRANSFER_DMA_MAP |
> > URB_NO_SETUP_DMA_MAP);
> >
> > - /* May be needed for some devices */
> > - usb_clear_halt(hid->dev, hid->urbin->pipe);
> > -
> > return hid;
>
> What is the usb_clear_halt doing here? If I add this back to 2.6.16, the
> keyboard on an IBM workstation works again. If I leave it out, it may
> eventually process a few keystrokes or it will be dead until I unplug
> it. But sometimes even that doesnt help.
> https://bugzilla.novell.com/show_bug.cgi?id=161066
> It seems to affect all/most IBM pSeries, but not Apple G5.
I originally added the clear_halt just on a hunch. It seemed to help my
HP keyboard, but it caused problems for other people so I removed it
again. It turned out that the blacklist entry was enough to make the HP
keyboard work okay.
I have no idea what's going on with your keyboards. Maybe they need an
equivalent blacklist entry.
Alan Stern
-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
