On Tue, 2 May 2006, Olaf Hering wrote: > On Thu, Nov 17, Alan Stern wrote: > > > This patch (as605) removes the private udev->serialize semaphore, relying > > instead on the locking provided by the embedded struct device's semaphore. > > The changes are confined to the core, except that the usb_trylock_device > > routine now uses the return convention of down_trylock rather than > > down_read_trylock (they return opposite values for no good reason). > > > > A couple of other associated changes are included as well: > > > > Now that we aren't concerned about HCDs that avoid using the > > hcd glue layer, usb_disconnect no longer needs to acquire the > > usb_bus_lock -- that can be done by usb_remove_hcd where it > > belongs. > > > > Devices aren't locked over the same scope of code in > > usb_new_device and hub_port_connect_change as they used to be. > > This shouldn't cause any trouble. > > > > Along with the preceding driver core patch, this needs a lot of testing. > > Ok, as noted in another (unrelated) thread, this patch breaks > appearently the keyboard all ppc64 pSeries systems, but not Apple G5. > Any ideas how to get a working 2.6.16 for them? Current Linus tree > doesnt work any better.
Are you certain this patch is responsible for the breakage? That is, did you build two kernels that differ only in whether or not this patch is included and compare their behavior? (I don't trust the git-bisect procedure to do this correctly.) Failure of a keyboard is not the sort of problem I would expect the patch to cause. The expected sort of problem is deadlock, where two processes are both trying to acquire the same lock. Do you see anything like that happening? Probably one of the processes would be khubd. As for 2.6.16... Can you log in without using the keyboard (say over ssh)? If you can, then use usbmon to trace what's happening with the keyboard. Maybe rmmod usbhid and modprobe usbhid while you're monitoring, so we can see the keyboard initialization sequence. Alan Stern ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
