[EMAIL PROTECTED] wrote:
> On Mon, 22 May 2006 00:48:31 -0700
> Phil Dibowitz <[EMAIL PROTECTED]> wrote:
> 
>> Is there still desire for that? If so, I can whip up a patch, or perhaps
>> Benjamin would prefer to do it.
> 
> I don't prefer it, because as I am not familiar with it, 
> it takes me really a lot of time.

Noted - if the concensus is to unify the flags, I'll do the extra work,
combine it with your patch and credit you for your part.

>> Personally, I think a single, more generic override is better that a
>> generic one and a non-generic one - but I'm fine if the conesus is to
>> proceed with Benjamin's patch.
>>
>>> -   US_FLAG(SINGLE_LUN,     0x00000001)                     \
>>> +   US_FLAG(SINGLE_LUN,             0x00000001)             \
>>>             /* allow access to only LUN 0 */                \
>>> -   US_FLAG(NEED_OVERRIDE,  0x00000002)                     \
>>> +   US_FLAG(NEED_OVERRIDE,          0x00000002)             \
>> ...
>>
>> Benjamin, why are you changing all the spacing here?
> 
> The new flag is longer than the old ones, thus the values wouldn't
> be any longer in one row. If it doesn't matter, delete them.

Ahhhh, I see. Fair enough.

-- 
Phil Dibowitz                             [EMAIL PROTECTED]
Freeware and Technical Pages              Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"Be who you are and say what you feel, because those who mind don't
matter and those who matter don't mind."
 - Dr. Seuss


Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to