On Friday 26 May 2006 5:16 am, Milan Svoboda wrote: > > Feedback and comments are highly appreciated.
To repeat the feedback I sent when you first posted these on the ARM list: (a) Split out the ARM platform patches from the USB patches. Your patches #2 and #3 still mix the two up. (b) <include/asm/arm/udc.h> is very wrong, it's not applicable to all ARM based USB peripheral controllers ... <include/asm/hardware/intel_udc.h> would be reasonable for this, though. Paying attention to feedback the first time you get it would be a timesaver. > PS: Who is gadget's maintainer? I do those honors. Russell King does the honors for ARM platform patches. The ARM patches will need to go through his patch database, which is part of why you should be splitting the USB and ARM patches apart. - Dave ------------------------------------------------------- All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel