Alan Stern wrote: > On Thu, 25 May 2006, Phil Dibowitz wrote: > >> @@ -115,10 +115,12 @@ static int slave_configure(struct scsi_d >> /* According to the technical support people at Genesys Logic, >> * devices using their chips have problems transferring more than >> * 32 KB at a time. In practice people have found that 64 KB >> - * works okay and that's what Windows does. But we'll be >> - * conservative; people can always use the sysfs interface to >> - * increase max_sectors. */ >> - if (le16_to_cpu(us->pusb_dev->descriptor.idVendor) == >> USB_VENDOR_ID_GENESYS && >> + * works okay and that's what Windows does. >> + * >> + * As it turns out, other devices needs this as well, so we've >> + * introduced the US_FL_MAX_SECTORS_64 flag. >> + */ > > I would remove most of the old comment, including all the stuff referring > to Genesys. Just say that some devices have trouble transferring more > than 32 KB at a time and others have trouble transferring more than 64 KB > at a time, and we will limit both types of devices to 32 KB (64 sectors). > Maybe also note that users can increase this limit through the max_sectors > sysfs file.
Seems reasonable. I'll update that before I submit the final version. > The rest of the patch looks fine. Thanks Alan. -- Phil Dibowitz [EMAIL PROTECTED] Freeware and Technical Pages Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss
signature.asc
Description: OpenPGP digital signature
