On Saturday 27 May 2006 13:30, Michael Hanselmann wrote: > Hello Andrew > > On Fri, May 26, 2006 at 01:16:30PM -0700, Andrew Morton wrote: > > > + up(&pdata->bd->sem); > > > + retval = appledisplay_bl_get_brightness(pdata->bd); > > > + if (retval >= 0) > > > + pdata->bd->props->brightness = retval; > > > + down(&pdata->bd->sem); > > > > Gee it's odd to go upping a semaphore on entry to a schedule_work() > > handler. What's going on here? > > As Benjamin wrote, I mixed up down() and up(). The patch below fixes > this. All other comments were due to that.
Also, HZ / 8 is not the right way to specify 125ms. It just happens to be right in the default desktop config where HZ == 1000. -- Regards, Christian Iversen ------------------------------------------------------- All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
