On Sat, 17 Jun 2006 22:09:49 -0300, "Luiz Fernando N. Capitulino" <[EMAIL 
PROTECTED]> wrote:

>   1. While you're are at it, please, create a new function to kill
>      'port', because now the code in port_release() and destroy_serial()
>      does exactly the same thing (to kill 'port').
> 
>   2. Just to be safe, do a 'port = NULL' after the call to kfree()

I agree about factorization, but I do not get what you are talking
about in comment #2. When we go through device_unregister,
serial->port[i] is set to NULL. When we collect unattached
ports, serial is about to be free anyway. I do not see an opportunity
to add extra zeroings, even after factorization.

-- Pete


_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to