On Tue, Jun 20, 2006 at 12:25:58PM -0700, Pete Zaitcev wrote: > On Mon, 19 Jun 2006 17:23:06 -0300, [EMAIL PROTECTED] wrote: > > > The goal is to make usb_serial_probe() smaller, clean and easy to follow. > > I'd like to challenge this assertion. The diffstat is not favourable: > > > drivers/usb/serial/usb-serial.c | 176 > > +++++++++++++++++++++++++++------------ > > 1 files changed, 120 insertions(+), 56 deletions(-)
I agree, I don't see the benifit here. Sure, that probe function does a _lot_ and has a zillion local variables. But you didn't reduce the number of local variables, and caused a few double error reports like Pete pointed out... What is the main reason for doing this? thanks, greg k-h _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
