On Tue, 20 Jun 2006 12:22:07 -0700
Pete Zaitcev <[EMAIL PROTECTED]> wrote:

| On Mon, 19 Jun 2006 17:23:10 -0300, [EMAIL PROTECTED] wrote:
| 
| > --- a/drivers/usb/serial/usb-serial.c
| > +++ b/drivers/usb/serial/usb-serial.c
| 
| > -           retval = type->attach (serial);
| > -           module_put(type->driver.owner);
| > -           if (retval < 0)
| > -                   goto probe_error;
| > -           if (retval > 0) {
| > -                   /* quietly accept this device, but don't bind to a 
serial port
| > -                    * as it's about to disappear */
| > -                   goto exit;
| > -           }
| > +
| > +   retval = driver_attach_it(serial, interface);
| > +   if (retval < 0) {
| > +           dev_err(&interface->dev, "%s - driver_attach failed\n",
| > +                   __FUNCTION__);
| > +           goto probe_error;
| > +   } else if (retval > 0) {
| > +           /*
| > +            * quietly accept this device, but don't bind to a serial port
| > +            * as it's about to desappear
| > +            */
| > +           goto exit;
| 
| You just love adding these else clauses everywhere, don't you.

 They come from the original code...

-- 
Luiz Fernando N. Capitulino


_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to