This is a note to let you know that I've just added the patch titled

     Subject: USB hub: don't return status > 0 from resume

to my gregkh-2.6 tree.  Its filename is

     usb-hub-don-t-return-status-0-from-resume.patch

This tree can be found at 
    http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/


>From [EMAIL PROTECTED] Mon Jun 19 12:12:45 2006
Date: Mon, 19 Jun 2006 15:12:38 -0400 (EDT)
From: Alan Stern <[EMAIL PROTECTED]>
To: Greg KH <[EMAIL PROTECTED]>
cc: USB development list <linux-usb-devel@lists.sourceforge.net>
Subject: USB hub: don't return status > 0 from resume
Message-ID: <[EMAIL PROTECTED]>

finish_device_resume() in the hub driver isn't careful always to return
a negative code in all the error pathways.  It also doesn't return 0 in
all the success pathways.  This patch (as724) fixes the behavior.

Signed-off-by: Alan Stern <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>

---
 drivers/usb/core/hub.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

--- gregkh-2.6.orig/drivers/usb/core/hub.c
+++ gregkh-2.6/drivers/usb/core/hub.c
@@ -1789,7 +1789,10 @@ static int finish_device_resume(struct u
         * and device drivers will know about any resume quirks.
         */
        status = usb_get_status(udev, USB_RECIP_DEVICE, 0, &devstatus);
-       if (status < 2)
+       if (status >= 0)
+               status = (status == 2 ? 0 : -ENODEV);
+
+       if (status)
                dev_dbg(&udev->dev,
                        "gone after usb resume? status %d\n",
                        status);


Patches currently in gregkh-2.6 which might be from [EMAIL PROTECTED] are

usb/usb-hub-don-t-return-status-0-from-resume.patch
usb/usb-storage-fix-race-between-reset-and-disconnect.patch
usb/usb-storage-unusual_devs-entry-for-motorola-razr-v3x.patch
usb/usbfs-use-the-correct-signal-number-for-disconnection.patch

Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to