i dunno why it has still not reached the list...I sent it 6 hours ago. -------- Original Message -------- Subject: [RFC] USB subsystem and the BKL Date: Wed, 28 Jun 2006 10:49:43 +0200 Reply-To: Franck <[EMAIL PROTECTED]> To: USB development list <linux-usb-devel@lists.sourceforge.net>
Hi, I noticed that the BKL is used a couple of time in the USB subsystem. Here is the list of the file that use it: drivers/usb/host/uhci-debug.c drivers/usb/misc/usblcd.c drivers/usb/misc/sisusbvga/sisusb.c drivers/usb/usb-skeleton.c drivers/usb/core/devio.c drivers/usb/core/devices.c I'm not sure to understand why it is used, specially in devices.c and devio.c files. In devices.c, it's used by usb_device_poll() and usb_device_lseek() functions. usb_device_poll(): It seems to use it only to protect usb_device_status structure. Can't we use a simple mutex here ? usb_device_lseek(): can we use the inode's mutex instead ? In devio.c, it's used by usbdev_open() and usbdev_lseek() functions. In both function can't we also use the inode's mutex instead ? Thanks Franck Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel