On 7/5/06, David Brownell <[EMAIL PROTECTED]> wrote:
> On Wednesday 05 July 2006 1:52 pm, Christopher Montgomery wrote:
> > On 7/5/06, Alan Stern <[EMAIL PROTECTED]> wrote:
> >
> > > I'm hampered by lack of detailed knowledge of the driver.  However it
> > > seems to me that those two calls should affect the schedule (cheap) and
> > > not the budget (expensive).
> >
> > Oh, hmm.  That's actually not a bad idea.  Some part of me is saying 'duh'.
>
> Part of you should also be saying "hey, isn't that exactly
> what Dave was referring to earlier?"  The current driver
> works exactly that way.

The current code at least partially rebudgets each time, so I *was*
following the way the current code works.  That call to
check_intr_schedule() in qh_schedule() isn't a no-op.  The fully
seperate budgeting could indeed make it a complete no-op, but I
followed the current pattern when qh budget/schedule was always done
at the same time.

I hadn't stopped to think that having a 100% seperable, persistent
budget was a way out because I had assumed that having interrupts
popping, throwing errors, while a different code path was
simultaneously removing the structures tossing the errors was
incorrect, unwanted behavior that should be fixed.  Now you have
impressed it is not, and you [all] have also mentioned a compromise
solution that's obvious.  Thanks.  This is the discussion I wanted to
be having.

> > > Go back and re-read what you yourself wrote above: the URB is resubmitted
> > > by core/hub.c.  Not by ehci-hcd.
> >
> > Quite right; I also stated clearly when I realized I was confused and
> > I corrected myself, but the argument continued.
>
> ... because in most other places you were saying that it's EHCI that
> resubmits the URB.  *BIG* difference.

Yes, I confused a point and it is a big difference. I restated, and my
current question w.r.t ehci-hcd still stands.  The resubmission code
is in ehci-hcd, and I pasted the code block. If there is still
confusion, I'll go back and restate from scratch very carefully.  I
really do want a complete understanding of what is happening and why,
and I'm resisting the hacker urge to argue for argument's sake ;-)

Monty

Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to