On 11.07.2006 23:51, Andrew Morton wrote: > Tilman Schmidt <[EMAIL PROTECTED]> wrote: > >>- class_device_create_file(cs->class, &class_device_attr_cidmode); >>+ if (class_device_create_file(cs->class, &class_device_attr_cidmode)) >>+ dev_warn(cs->dev, "could not create sysfs attribute\n"); > > With this change we'll emit a warning (actually it's an error - I'll make > it dev_err(), OK?)
Fine with me. It's not fatal to the driver which is quite capable of operating without that sysfs file, but ok, it *is* an error, and in fact, if class_device_create_file() fails there must be something seriously wrong. > and then we'll continue execution, pretending that the > sysfs file actually got registered. Later, we'll try to unregister a > not-registered sysfs file. Well, from my reading of the source, class_device_remove_file() should be able to cope with that. The alternative would be to save off the fact that the original creation failed somewhere in the driver data, for the sole purpose of avoiding calling class_device_remove_file() for it later. -- Tilman Schmidt E-Mail: [EMAIL PROTECTED] Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
