On Wed, Jul 12, 2006 at 09:06:11AM +0200, Matthias Urlichs wrote: > Signed-Off-By: Matthias Urlichs <[EMAIL PROTECTED]> > --- > drivers/usb/serial/option.c | 32 +------------------------------- > 1 files changed, 1 insertions(+), 31 deletions(-) > > > Greg KH: > > Hm, can you stop adding changelog stuff to the driver itself? That will > > just get HUGE over time and can be found in the git changelog > > information. > > > OK. Removed, in fact. > > > > +#include <linux/version.h> > > > > Why is version.h needed? > > > Bah. Leftover from a version for a customer that had to run on 2.6.14. > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > index 60f56ce..29249b4 100644 > --- a/drivers/usb/serial/option.c > +++ b/drivers/usb/serial/option.c > @@ -9,36 +9,7 @@ > > Portions copied from the Keyspan driver by Hugh Blemings <[EMAIL > PROTECTED]> > > - History: > - > - 2005-05-19 v0.1 Initial version, based on incomplete docs > - and analysis of misbehavior with the standard driver > - 2005-05-20 v0.2 Extended the input buffer to avoid losing > - random 64-byte chunks of data > - 2005-05-21 v0.3 implemented chars_in_buffer() > - turned on low_latency > - simplified the code somewhat > - 2005-05-24 v0.4 option_write() sometimes deadlocked under heavy load > - removed some dead code > - added sponsor notice > - coding style clean-up > - 2005-06-20 v0.4.1 add missing braces :-/ > - killed end-of-line whitespace > - 2005-07-15 v0.4.2 rename WLAN product to FUSION, add FUSION2 > - 2005-09-10 v0.4.3 added HUAWEI E600 card and Audiovox AirCard > - 2005-09-20 v0.4.4 increased recv buffer size: the card sometimes > - wants to send >2000 bytes. > - 2006-04-10 v0.5 fixed two array overrun errors :-/ > - 2006-04-21 v0.5.1 added support for Sierra Wireless MC8755 > - 2006-05-15 v0.6 re-enable multi-port support > - 2006-06-01 v0.6.1 add COBRA > - 2006-06-01 v0.6.2 add backwards-compatibility stuff > - 2006-06-01 v0.6.3 add Novatel Wireless > - 2006-06-01 v0.7 Option => GSM > - 2006-06-01 v0.7.1 add COBRA2 > - 2006-07-11 v0.7.2 Make driver short names unique > - forgot .ioctl entry > - 2006-07-11 v0.7.3 add ANYDATA > + History: see the git log. > > Work sponsored by: Sigos GmbH, Germany <[EMAIL PROTECTED]> > > @@ -68,7 +39,6 @@ #include <linux/tty.h> > #include <linux/tty_flip.h> > #include <linux/module.h> > #include <linux/usb.h> > -#include <linux/version.h> > #include "usb-serial.h"
Hm, can you just resend a new patch, not an incremental one? I didn't apply the first one yet :) thanks, greg k-h ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
