--- Andrew Morton <[EMAIL PROTECTED]> wrote: > On Tue, 11 Jul 2006 23:38:41 -0700 (PDT) > Aleksey Gorelov <[EMAIL PROTECTED]> wrote: > > > If some problem occurs during ehci startup, for instance, request_irq > > fails, echi hcd driver > > tries it best to cleanup, but fails to unregister reboot notifier, which in > > turn leads to > crash on > > reboot/poweroff. Below is the patch against current git to fix this. > > I did not check if the same problem existed for uhci/ohci host drivers. > > This patch causes hangs at reboot/shutdown/suspend time. See > http://www.zip.com.au/~akpm/linux/patches/stuff/dsc03597.jpg > Oops, I did not test it with suspend/resume stuff, sorry. The problem is that ehci_run is called from resume without its counterpart ehci_stop in suspend, so notifier ends up registered twice.
David, Alan, Do you think it is Ok to unregister reboot notifier in ehci_run before registering one to make sure there is no 'double registering' of notifier, or is it better to move register/unregister reboot notifier from ehci_run/ehci_stop completely to some other place ? Aleks. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
