On 7/20/06, Kumar Gala <[EMAIL PROTECTED]> wrote: > > On Jul 20, 2006, at 6:42 AM, Li Yang-r58472 wrote: > > > Another one in header file. > > > > --- > > diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h > > index 679c1cd..8da2774 100644 > > --- a/drivers/usb/host/ehci.h > > +++ b/drivers/usb/host/ehci.h > > @@ -642,7 +642,7 @@ #endif > > > > > > / > > *--------------------------------------------------------------------- > > - > > ---*/ > > > > -#ifdef CONFIG_PPC_83xx > > +#ifdef CONFIG_MPC834x > > /* Some Freescale processors have an erratum in which the TT > > * port number in the queue head was 0..N-1 instead of 1..N. > > */ > > Do we really want to make this change. What harm is there in having > the ehci support for MPC834x build on all 83xx processors? I can't > imagine we are going to config in support for ehci on anything that > is MPC834x at this point and if you do, your device tree isn't going > to have nodes in it so the drivers not going to bind against anything. >
It's not very harmful. But it will cause some misunderstanding. There were already some guys trying to use the 834x USB driver on 836x and 832x. Anyway, it's a trivial patch. Please apply if it doesn't cause much trouble. > Finally, I got to believe Freescale's going to build some MPC83xx in > the future with the high speed USB IP. I can't tell exactly. But it's not likely to integrate this IP into a chip with QE/CPM support. As QE/CPM has already provided full speed USB support, and the USB speed is not very important for Netcomm processors. > > - kumar > > > > >> -----Original Message----- > >> From: [EMAIL PROTECTED] > >> [mailto:[EMAIL PROTECTED] On Behalf Of > > Kumar Gala > >> Sent: Friday, July 14, 2006 9:52 PM > >> To: Li Yang-r58472 > >> Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; > >> linux-usb-devel@lists.sourceforge.net > >> Subject: Re: [linux-usb-devel] [PATCH] Fix Freescale high-speed USB > > hostdependency > >> > >> Acked-by: Kumar Gala <[EMAIL PROTECTED]> > >> > >> On Jul 14, 2006, at 6:58 AM, Li Yang wrote: > >> > >>> The high-speed USB SOC only exists on MPC834x family not MPC83xx > >>> family. > >>> > >>> Signed-off-by: Li Yang <[EMAIL PROTECTED]> > >>> > >>> --- > >>> > >>> drivers/usb/host/ehci-hcd.c | 2 +- > >>> 1 files changed, 1 insertions(+), 1 deletions(-) > >>> > >>> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci- > >>> hcd.c index 79f2d8b..3af1844 100644 > >>> --- a/drivers/usb/host/ehci-hcd.c > >>> +++ b/drivers/usb/host/ehci-hcd.c > >>> @@ -892,7 +892,7 @@ #include "ehci-pci.c" > >>> #define EHCI_BUS_GLUED > >>> #endif > >>> > >>> -#ifdef CONFIG_PPC_83xx > >>> +#ifdef CONFIG_MPC834x > >>> #include "ehci-fsl.c" > >>> #define EHCI_BUS_GLUED > >>> #endif > > > > _______________________________________________ > Linuxppc-dev mailing list > [EMAIL PROTECTED] > https://ozlabs.org/mailman/listinfo/linuxppc-dev > ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
