On Tue, 25 Jul 2006, Pete Zaitcev wrote:
> I did not do an exhaustive search. I saw the place you mention in
> transport.c, however I have one little personal problem there, an
> unfinished business. Remember those toggles? Well, we abandoned my
> idea of clearing them preventively, but now we (RHEL 4) clear them
> as part of the recovery. I'm still thinking if I should push this
> on you & Matt, so I didn't touch it. I have this patch for now:
> + /*
> + * A timeout could have happened becasue we reloaded and
> + * inherited a nonzero toggle. And there is no way to know!
> + * We clear and hope for the best. Bugs 129165, 160308.
> + */
> + US_DEBUGP("clearing after halt for pipe 0x%x\n", pipe);
> + usb_stor_clear_halt(us, pipe);
> return USB_STOR_XFER_ERROR;
>
> /* babble - the device tried to send more than we wanted to read */
>
> As see, this makes this check meaningful. I need to do something about it.
Isn't it true that whenever this error occurs, usb-storage will do a port
reset? And won't that fix up the toggles for you?
Alan Stern
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
