On Thursday 03 August 2006 7:11 am, Luiz Fernando N. Capitulino wrote: >
> __usb_endpoint_is_in() > __usb_endpoint_is_out() > __usb_endpoint_is_bulk() > __usb_endpoint_is_int() Why the double underscores? Those make perfectly reasonable functions in their own right. Ditto for "is_iso", 'is_interrupt". > usb_endpoint_is_bulk_in() > usb_endpoint_is_bulk_out() > usb_endpoint_is_int_in() > usb_endpoint_is_int_out() > > Which is flexible, is still good, but looks too much macros to me. The "is_in" and "is_out" tests are more common than the "is_bulk_in" etc., in my experience ... > Oh, BTW, I didn't add a macro to check isochronous endpoints because > they're not so common in USB driver's code. But if we're going to make > the API complete, I think we should add it. Yes. - Dave ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
