On Wed, 9 Aug 2006, Luiz Fernando N. Capitulino wrote:

> --- linux-2.6.orig/drivers/usb/usb-skeleton.c
> +++ linux-2.6/drivers/usb/usb-skeleton.c
> @@ -1,5 +1,5 @@
>  /*
> - * USB Skeleton driver - 2.0
> + * USB Skeleton driver - 2.1
>   *
>   * Copyright (C) 2001-2004 Greg Kroah-Hartman ([EMAIL PROTECTED])
>   *

> @@ -162,8 +162,8 @@ static void skel_write_bulk_callback(str
>  static ssize_t skel_write(struct file *file, const char *user_buffer, size_t 
> count, loff_t *ppos)
>  {
>       struct usb_skel *dev;
> -     int retval = 0;
> -     struct urb *urb = NULL;
> +     int retval;
> +     struct urb *urb;
>       char *buf = NULL;
>       size_t writesize = min(count, (size_t)MAX_TRANSFER);

We must not be working from the same code base.  The first hunk listed
above is already in Greg's development tree, and the second would cause
both urb and retval to be used without proper initialization in some of
the error paths.

Alan Stern


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to