On Tue, Aug 15, 2006 at 02:04:42AM +0200, Adrian Bunk wrote:
> The Coverity Checker spotted the following obvious NULL dereference:
>
> <-- snip -->
>
> ...
> static int cypress_probe(struct usb_interface *interface,
> const struct usb_device_id *id)
> {
> ...
> if (dev == NULL) {
> dev_err(&dev->udev->dev, "Out of memory!\n");
> goto error;
> }
> ...
> }
> ...
>
> <-- snip -->
Thanks for letting me know, the patch below should fix this.
greg k-h
------------
From: Greg Kroah-Hartman <[EMAIL PROTECTED]>
Subject: USB: fix bug in cypress_cy7c63.c driver
This was pointed out by Adrian Bunk <[EMAIL PROTECTED]>, as found by the
Coverity Checker.
Cc: Adrian Bunk <[EMAIL PROTECTED]>
Cc: Oliver Bock <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
drivers/usb/misc/cypress_cy7c63.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- gregkh-2.6.orig/drivers/usb/misc/cypress_cy7c63.c
+++ gregkh-2.6/drivers/usb/misc/cypress_cy7c63.c
@@ -208,7 +208,7 @@ static int cypress_probe(struct usb_inte
/* allocate memory for our device state and initialize it */
dev = kzalloc(sizeof(*dev), GFP_KERNEL);
if (dev == NULL) {
- dev_err(&dev->udev->dev, "Out of memory!\n");
+ dev_err(&interface->dev, "Out of memory!\n");
goto error;
}
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
