Hi Alan,

Alan Stern wrote:
> Greg:
> 
> Rather than using a home-brewed test (dev->dma_mask != NULL) to
> indicate which host controller devices use DMA, this patch (as770)
> invokes the standard dma_supported() API and caches the result.
> 

[snip]

> Index: usb-2.6/include/linux/usb.h
> ===================================================================
> --- usb-2.6.orig/include/linux/usb.h
> +++ usb-2.6/include/linux/usb.h
> @@ -270,6 +270,7 @@ struct usb_bus {
>       struct device *controller;      /* host/master side hardware */
>       int busnum;                     /* Bus number (in order of reg) */
>       char *bus_name;                 /* stable id (PCI slot_name etc) */
> +     u8 uses_dma;                    /* Does the host controller use DMA? */

Why using 'u8' (which is likely expanded to an int) ? Can we use a bit field
instead as defined below ?

>       unsigned is_b_host:1;           /* true during some HNP roleswitches */
>       unsigned b_hnp_enable:1;        /* OTG: did A-Host enable HNP? */
> 

                Franck

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to