On Wed, 16 Aug 2006, Pete Zaitcev wrote:

> On Wed, 16 Aug 2006 16:59:11 -0400 (EDT), Alan Stern <[EMAIL PROTECTED]> 
> wrote:
> 
> > Signed-off-by: Alan Stern <[EMAIL PROTECTED]>
> ACK
> 
> > +++ usb-2.6/drivers/usb/mon/mon_main.c
> > @@ -303,6 +303,7 @@ static void mon_bus_init(struct dentry *
> >     // usb_bus_get(ubus);
> >     mbus->u_bus = ubus;
> >     ubus->mon_bus = mbus;
> > +   mbus->uses_dma = ubus->uses_dma;
> 
> This looks silly, but it's either that, or a double indirect reference
> to the USB bus sturct. So, it's unavoidable.

I don't mind doing a double-indirect reference, but this seemed easier.  
And cleaner, especially if the patch that adds ubus->uses_dma doesn't get 
accepted.  In that case it would turn into a triple-indirect reference:

        mbus->ubus->controller->dma_mask != NULL

Alan Stern


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to